Skip to content

Add timeout errors to be kept when raise_on_failure is false #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2022
Merged

Add timeout errors to be kept when raise_on_failure is false #174

merged 2 commits into from
Jul 20, 2022
+36 −3

Conversation

@brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented Jul 14, 2022

Fixes #172

@brunoocasali brunoocasali added the bug Something isn't working label Jul 14, 2022
@brunoocasali brunoocasali mentioned this pull request Jul 14, 2022
Closed
brunoocasali
brunoocasali commented Jul 18, 2022
View reviewed changes
spec/integration_spec.rb
end

describe 'Raise on failure' do
before { Vegetable.instance_variable_set('@ms_indexes', nil) }
Copy link
Member Author

@brunoocasali brunoocasali Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required because I'm messing with the internals of that class when I'm adding/removing the mocks to raise the TimeoutError.

@brunoocasali brunoocasali requested review from curquiza and mdubus July 19, 2022 18:02
curquiza
curquiza reviewed Jul 20, 2022
View reviewed changes
@brunoocasali @curquiza
Update lib/meilisearch-rails.rb
0a93c05 
Co-authored-by: Clémentine Urquizar - curqui <[email protected]>
curquiza
curquiza approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top moumoute!

@brunoocasali
Copy link
Member Author

brunoocasali commented Jul 20, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 20, 2022

Build succeeded:

@bors bors bot merged commit da629f4 into main Jul 20, 2022
@bors bors bot deleted the fix-172 branch July 20, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curquiza curquiza curquiza approved these changes

@mdubus mdubus Awaiting requested review from mdubus

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MeiliSearch::TimeoutError · The request was not processed in the expected time. execution expired

3 participants

@brunoocasali @curquiza