Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort_facet_values_by to Faceting model #848

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Add sort_facet_values_by to Faceting model #848

merged 3 commits into from
Sep 21, 2023

Conversation

sanders41
Copy link
Collaborator

@sanders41 sanders41 commented Sep 20, 2023

Pull Request

@curquiza this is what is needed in addition to the code samples for #829

Related issue

Fixes #829

What does this PR do?

  • Adds sort_facet_values_by to the Faceting model

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the enhancement New feature or request label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a4b6513) 100.00% compared to head (715a9e9) 100.00%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #848   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          720       721    +1     
=========================================
+ Hits           720       721    +1     
Files Changed Coverage Δ
meilisearch/models/index.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sanders41

I let you merge when you want 😄

@sanders41
Copy link
Collaborator Author

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 21, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit d31673b into main Sep 21, 2023
11 checks passed
@meili-bors meili-bors bot deleted the facet-settings branch September 21, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.3] Sort facets value by alphanumerical or count order
2 participants