Skip to content

Conversation

@sanders41
Copy link
Collaborator

@bidoubiwa bidoubiwa self-requested a review May 21, 2021 21:34
@curquiza curquiza requested a review from bidoubiwa May 24, 2021 11:47
@curquiza
Copy link
Member

curquiza commented May 24, 2021

Shouldn't this method being applied for updateDocuments as well, as described in this issue: meilisearch/integration-guides#106?

@sanders41
Copy link
Collaborator Author

Shouldn't this method being applied for updateDocuments as well, as described in this issue: meilisearch/integration-guides#106?

So also add a update_documents_in_batches method correct? Yes, this would make sense.

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 Thanks a lot

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 24, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants