Code samples changes related to Meilisearch release (v0.28.0) #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bot
added
documentation
curquiza
reviewed
Jul 6, 2022
curquiza
reviewed
Jul 6, 2022
.code-samples.meilisearch.yaml
Outdated
| $client->index('movies')->delete(); | ||
| get_one_document_1: |- | ||
| $client->index('movies')->getDocument(25684); | ||
| $client->index('movies')->getDocument(25684, (new IndexesQuery())->setFields(['id', 'title', 'poster', 'release_date'])); |
Member
There was a problem hiding this comment.
If I'm correct it's impossible to use setFields currently with getDocument even if it's possible with getDocuments
Member
There was a problem hiding this comment.
Actually, it is possible! But not using an object like the other lists
I've opted to just use the fields in this case because I hardly believe the getDocument will increase their public API in the future.
Member
There was a problem hiding this comment.
Ok! thanks!
I've updated the code sample, let me know if it's correct then 😄
Co-authored-by: Bruno Casali <[email protected]>
brunoocasali
added a commit
that referenced
this pull request
Jul 11, 2022
* Update .code-samples.meilisearch.yaml * Update code samples * Fix list_indexes code sample * Fix get_one_document_1 code sample * Update .code-samples.meilisearch.yaml Author: Clémentine Urquizar <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is auto-generated.
Update the code-samples.meilisearch.yml according to the integration-guides issue for more information and the complete description about what should be done here check that issue.