-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove axios and change browser bundle name #573
Conversation
f91e25a
to
681ccb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not mentioned in the PR description, but has the .browser.js
extension been removed? I would say yes 🙂
A bad URL will now raise a bad URL type instead of a
meiliSearchCommunicationError
What is a bad URL? A wrong formatted URL?
Yes it has been replaced with |
73673e8
to
ae43f3a
Compare
This PR removes axios and replace it with fetch.
Browser bundle will use the native
fetch
api and cjs bundle will use thefetch
pollyfill.Other additions:
umd
format now work on both node AND browser 🙌 fixes: Use iife for browser and cjs for node #470cjs
format has been removednode
environment anddom
environment.yarn watch
to help ease the developmentStructural changes:
post, get, put, ...
methods inside its object.This PR introduces some breakings:
index.deleteIndex()
now returnsundefined
instead of an empty stringmeiliSearchCommunicationError