Improve examples and their READMEs #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
changed the title
bidoubiwa
added
skip-changelog
curquiza
requested changes
Jul 20, 2020
examples/node/README.md
Outdated
|
|
||
| ## Try out | ||
|
|
||
| To try it out you just need to execute the files: |
There was a problem hiding this comment.
Suggested change
| To try it out you just need to execute the files: | |
| To try it out you just need to execute the file: |
There was a problem hiding this comment.
It's files because their are more than one file in this directory,
There was a problem hiding this comment.
But as the command below is node search_example.js, this is one file, right?
There was a problem hiding this comment.
It is one of the files that are present. Maybe I should add For example:
curquiza
changed the title
curquiza
changed the title
curquiza
requested changes
Jul 20, 2020
End of file line Editorconfig enabled Linting and fixes Spacing Update examples/typescript-browser/README.md Co-authored-by: Clémentine Urquizar <[email protected]> Update examples/typescript-browser/README.md Co-authored-by: Clémentine Urquizar <[email protected]> Update examples/typescript-node/README.md Co-authored-by: Clémentine Urquizar <[email protected]> Update examples/typescript-node/README.md Improve wording
bidoubiwa
force-pushed
the
improve_examples
branch
from
963dec3
to
e5f6a66
Compare
curquiza
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.