Add null to Embedder type #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdubus
approved these changes
Apr 22, 2024
mdubus
merged commit f2f9b18
into
meilisearch:bump-meilisearch-v1.8.0
4 of 6 checks passed
meili-bors bot
added a commit
that referenced
this pull request
May 6, 2024
1648: Update version for the next release (v0.39.0) r=brunoocasali a=meili-bot ## 🚀 Enhancements * feat: hybrid search improvements for v1.8.x (#1647) `@mdubus` * Add `null` to Embedder type (#1646) `@amit-ksh` * Add searchCutoffMs index setting (#1643, #1645) `@amit-ksh` ```js client.index('movies').getSearchCutoffMs() client.index('movies').updateSearchCutoffMs(150) client.index('movies').resetSearchCutoffMs() ``` ## ⚙️ Maintenance/misc * Update ESLint, Prettier, TypeScript and fix/improve their configuration files (#1616) `@flevi29` * Fix code style after configuration changes (#1638) `@brunoocasali` Thanks again to `@amit-ksh,` `@brunoocasali,` `@curquiza,` `@flevi29,` `@mdubus,` `@meili-bors[bot]` ! 🎉 Co-authored-by: meili-bot <[email protected]>
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #1637
What does this PR do?
nulltype to EmbedderPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!