-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add export for MeiliSearch as Meilisearch #1601
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1601 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 22 22
Lines 819 819
Branches 109 109
=======================================
Hits 798 798
Misses 20 20
Partials 1 1
☔ View full report in Codecov by Sentry. |
@Strift is that what you're expecting? |
Hey there, Thanks for opening a pull request. @brunoocasali yes it is. I've looked at the code, and it looks good to me. But for some reason, the tests failed for Node.js 18. I don't know the code base well enough to understand it thought. |
The failing test I believe is just a flaky! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @Dhoni77, for your PR! :)
bors merge
Build succeeded:
|
Pull Request
Related issue
Fixes #1600
What does this PR do?
Add export for
MeiliSearch
class with the identifierMeilisearch
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!