Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add export for MeiliSearch as Meilisearch #1601

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Dhoni77
Copy link
Contributor

@Dhoni77 Dhoni77 commented Nov 13, 2023

Pull Request

Related issue

Fixes #1600

What does this PR do?

Add export for MeiliSearch class with the identifier Meilisearch

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (66060f7) 97.43% compared to head (7826ebe) 97.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1601   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files          22       22           
  Lines         819      819           
  Branches      109      109           
=======================================
  Hits          798      798           
  Misses         20       20           
  Partials        1        1           
Files Coverage Δ
src/browser.ts 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brunoocasali
Copy link
Member

@Strift is that what you're expecting?

@Strift
Copy link
Collaborator

Strift commented Nov 16, 2023

Hey there,

Thanks for opening a pull request.

@brunoocasali yes it is. I've looked at the code, and it looks good to me. But for some reason, the tests failed for Node.js 18.

I don't know the code base well enough to understand it thought.

@brunoocasali
Copy link
Member

The failing test I believe is just a flaky!

@brunoocasali brunoocasali added the enhancement New feature or request label Nov 16, 2023
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Dhoni77, for your PR! :)

bors merge

Copy link
Contributor

meili-bors bot commented Nov 16, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Meilisearch export
3 participants