Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update typescript to 4.9.5 (ts) #1444

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Update typescript to 4.9.5 (ts) #1444

merged 1 commit into from
Feb 6, 2023

Conversation

bidoubiwa
Copy link
Contributor

The library was not compatible with environments using typescript v4.9.5 causing typing errors.

@bidoubiwa bidoubiwa added the bug Something isn't working label Feb 6, 2023
@bidoubiwa bidoubiwa requested a review from alallema February 6, 2023 11:26
alallema
alallema approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidoubiwa
Copy link
Contributor Author

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Feb 6, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 4b21e82 into main Feb 6, 2023
@meili-bors meili-bors bot deleted the update_typescript_to_v4.9.5 branch February 6, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidoubiwa @alallema