Update error codes for Meilisearch v1.0.0 #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
changed the title
bidoubiwa
added
the
breaking-change
brunoocasali
approved these changes
Jan 31, 2023
mdubus
reviewed
Feb 1, 2023
| IMMUTABLE_API_KEY_CREATED_AT = 'immutable_api_key_created_at', | ||
|
|
||
| /** @see https://docs.meilisearch.com/errors/#immutable_api_key_update_at */ | ||
| IMMUTABLE_API_KEY_UPDATE_AT = 'immutable_api_key_update_at', |
There was a problem hiding this comment.
Since we have IMMUTABLE_API_KEY_CREATED_AT above, why isn't this one called IMMUTABLE_API_KEY_UPDATED_AT ("updated" with a "d")?
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Feb 1, 2023
1438: Update error codes for Meilisearch v1.0.0 r=bidoubiwa a=bidoubiwa See [specification](meilisearch/specifications#212) Co-authored-by: Charlotte Vermandel <[email protected]>
|
Build failed: |
|
bors try |
tryBuild failed: |
bidoubiwa
force-pushed
the
update_error_codes_for_v1.0.0
branch
from
d9192b9
to
8ab11c2
Compare
|
bors try |
tryBuild failed: |
bidoubiwa
added a commit
that referenced
this pull request
Feb 1, 2023
* Add new error codes * Add missing error_codes and remove old ones
meili-bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
1440: Update version for the next release (v0.31.0) r=bidoubiwa a=bidoubiwa This version makes this package compatible with Meilisearch v1.0.0 🎉 Check out the changelog of [Meilisearch v1.0.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.0.0) for more information on the changes. ##⚠️ Breaking change - Some error codes were added #1438 - Some error codes were removed #1438 Co-authored-by: Charlotte Vermandel <[email protected]>
meili-bors bot
added a commit
that referenced
this pull request
Feb 6, 2023
1426: build(deps-dev): bump @rollup/plugin-json from 5.0.2 to 6.0.0 r=bidoubiwa a=dependabot[bot] Bumps [`@rollup/plugin-json](https://github.com/rollup/plugins/tree/HEAD/packages/json)` from 5.0.2 to 6.0.0. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rollup/plugins/blob/master/packages/json/CHANGELOG.md"><code>`@rollup/plugin-json</code>'s` changelog</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <p><em>2022-12-17</em></p> <h3>Breaking Changes</h3> <ul> <li>fix: log more robustly when JSON parsing fails <a href="https://github-redirect.dependabot.com/rollup/plugins/pull/1361">#1361</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rollup/plugins/commit/445f8ca88c7a903b14601a7bc9e0bf9d9436413d"><code>445f8ca</code></a> fix(json): cannot be imported by rollup (<a href="https://github.com/rollup/plugins/tree/HEAD/packages/json/issues/81">#81</a>)</li> <li><a href="https://github.com/rollup/plugins/commit/6c1cc760943f8307debc6e068ea4b61e3caec57f"><code>6c1cc76</code></a> chore: remove placeholder security script from each plugin (<a href="https://github.com/rollup/plugins/tree/HEAD/packages/json/issues/77">#77</a>)</li> <li><a href="https://github.com/rollup/plugins/commit/03a2e576b27c0344475e51d397d730054df49629"><code>03a2e57</code></a> chore: fix linting errors that snuck through</li> <li><a href="https://github.com/rollup/plugins/commit/4f0bff541d788e273f5419e0f9c8bab8a88752cc"><code>4f0bff5</code></a> feat: export Rollup*Options interfaces (<a href="https://github.com/rollup/plugins/tree/HEAD/packages/json/issues/53">#53</a>)</li> <li><a href="https://github.com/rollup/plugins/commit/3d6132a0285c372d0fa9d6d5b685024ac255be8f"><code>3d6132a</code></a> chore: align scripts to use pnpm run</li> <li><a href="https://github.com/rollup/plugins/commit/e3e20e9e346ba0cdf7fc059d5470be28ecc3292a"><code>e3e20e9</code></a> chore: migrate rollup-plugin-yaml (<a href="https://github.com/rollup/plugins/tree/HEAD/packages/json/issues/36">#36</a>)</li> <li><a href="https://github.com/rollup/plugins/commit/bb446bd008fdcc116c09dd3baeacda240b3a33b5"><code>bb446bd</code></a> chore: migrate rollup-plugin-json (<a href="https://github.com/rollup/plugins/tree/HEAD/packages/json/issues/30">#30</a>)</li> <li>See full diff in <a href="https://github.com/rollup/plugins/commits/url-v6.0.0/packages/json">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)` You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 1440: Update version for the next release (v0.31.0) r=bidoubiwa a=bidoubiwa This version makes this package compatible with Meilisearch v1.0.0 🎉 Check out the changelog of [Meilisearch v1.0.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.0.0) for more information on the changes. ##⚠️ Breaking change - Some error codes were added #1438 - Some error codes were removed #1438 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Charlotte Vermandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See specification