remove Document and Documents
#1424
Conversation
| @@ -327,10 +327,10 @@ class Index<T extends Record<string, any> = Record<string, any>> { | |||
| * @param parameters - Parameters applied on a document | |||
| * @returns Promise containing Document response | |||
| */ | |||
| async getDocument<T = Record<string, any>>( | |||
| async getDocument<D extends Record<string, any> = T>( | |||
There was a problem hiding this comment.
Why do we need to keep extending here? Maybe there is a case that I don't see. Is D = T not enough ?
There was a problem hiding this comment.
T extends Record<string, any> on index creation but you can override it by Index<{}>().getDocument<number>()
There was a problem hiding this comment.
I see, but imagine I want to get Movie documents
type Movie = {
id: number
name: string
}Then, overwrite the type of index by doing like you said client.index('x').getDocument<Movie>(1).
In this case Movie is doing to be D. But why does D needs to be extended from Record<string, any> ? I'm not expecting any other field in my Movie.
Sorry if I'm misunderstanding something
There was a problem hiding this comment.
your type Movie already extends Record<string, any>
it's valid to call getDocument<Movie>() with your type example
There was a problem hiding this comment.
In the same vain, should we have added that as well in search ?
Line 102 in b1ed904
async searchGet<D extends Record<string, any>> = T>( 
bidoubiwa
added
skip-changelog
|
bors merge |
Pull Request
Related issue
Fixes #1421
What does this PR do?
remove
DocumentandDocumentsPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!