Add pagination feature for v0.30.0 #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
requested changes
Oct 27, 2022
There was a problem hiding this comment.
I'm not sure if I understood the PR, because it seems to me the default response is the finite pagination.
But according to my understanding, the default behavior should be the estimated one 🤔
So I see most of the tests here have been changed because of that change. Please let me know if I'm wrong 😄
| expect(response.hitsPerPage === 1).toBeTruthy() | ||
| expect(response.page === 1).toBeTruthy() | ||
| expect(response.totalPages === 7).toBeTruthy() | ||
| expect(response.totalHits === 7).toBeTruthy() |
There was a problem hiding this comment.
It should only respond with the following:
{
"hits": [
{
...
}
],
"query": "",
"processingTimeMs": 0,
"limit": 1,
"offset": 0,
"estimatedTotalHits": xx
}So your test should match the estimated pagination response.
brunoocasali
approved these changes
Nov 7, 2022
meili-bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
1406: build(deps-dev): bump @rollup/plugin-commonjs from 23.0.2 to 23.0.3 r=bidoubiwa a=dependabot[bot] Bumps [`@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs)` from 23.0.2 to 23.0.3. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md"><code>`@rollup/plugin-commonjs</code>'s` changelog</a>.</em></p> <blockquote> <h2>v23.0.3</h2> <p><em>2022-11-27</em></p> <h3>Bugfixes</h3> <ul> <li>fix: correctly wrap a default class export from cjs module <a href="https://github-redirect.dependabot.com/rollup/plugins/pull/1350">#1350</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rollup/plugins/commit/2114cf7c1ce269100c692cb06377d90cecd73fdb"><code>2114cf7</code></a> chore(release): commonjs v23.0.3</li> <li><a href="https://github.com/rollup/plugins/commit/ab052169c1719d57429fa28948268758a3b5e281"><code>ab05216</code></a> fix(commonjs): correctly wrap a default class export from cjs module (<a href="https://github.com/rollup/plugins/tree/HEAD/packages/commonjs/issues/1350">#1350</a>)</li> <li>See full diff in <a href="https://github.com/rollup/plugins/commits/commonjs-v23.0.3/packages/commonjs">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)` You can trigger a rebase of this PR by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 1408: Update version for the next release (v0.30.0) r=bidoubiwa a=bidoubiwa This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ## 🚀 Enhancements - New `pagination` strategy with the search parameters`page` and `hitsPerPage` #1372 - New filters on `getTasks`: `uid`, `beforeEnqueuedAt`, `afterEnqueuedAt`, ... see #1376 - New `client.cancelTasks` method that lets you cancel `enqueued` and `processing` tasks #1379 - New `client.deleteTasks` method that lets you deleted tasks #1382 - New `client.swapIndexes` method that lets you swap two indexes #1384 ##⚠️ Breaking change - Parameters on `getTasks` name changes: #1391 - `status` -> `statuses` - `index_uid` -> `index_uids` - `type` -> `types` - Task detail `receivedDocumentIds` renamed to `providedIds` #1386 - Remove `batchUid` from `Task` class #1388 - Error field in `Task` is now always present and has a `null` value when there are no errors #1389 - Add and rename some error codes: #1393 - (ts) Make all the fields of details field of TaskObject optional (#1398) `@amit-ksh` - (ts) Make all the fields of details field of TaskObject optional (#1398) `@amit-ksh` Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Charlotte Vermandel <[email protected]> Co-authored-by: cvermand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new page selection component
TODO:
pageandhitsPerPagepage,hitsPerPage,totalHits,totalPagesResponse:
pageis optionalhitsPerPageis optionaltotalPagesis optionaltotalHitsis optionalTests