Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MatchingStrategies enum type available to import #1358

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Make MatchingStrategies enum type available to import #1358

merged 2 commits into from
Oct 13, 2022

Conversation

jimmyruann
Copy link
Contributor

Pull Request

Related issue

Fixes #1350

What does this PR do?

  • Change the way MatchingStrategies enum is defined

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

bidoubiwa
bidoubiwa approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly on my other typescript projects ✨

Thanks for this great addition

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 13, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit bd914b8 into meilisearch:main Oct 13, 2022
@bidoubiwa
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@bidoubiwa bidoubiwa added the enhancement New feature or request label Oct 13, 2022
@bidoubiwa bidoubiwa changed the title Update MatchingStrategies enum type Make MatchingStrategies enum type available to import Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatchingStrategies const enums when the --isolateModules flag is provided
2 participants
@jimmyruann @bidoubiwa