Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add faceting index settings methods #1344

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Add faceting index settings methods #1344

merged 4 commits into from
Oct 4, 2022

Conversation

Ugzuzg
Copy link
Contributor

@Ugzuzg Ugzuzg commented Oct 3, 2022

Pull Request

Related issue

Fixes #1299

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@Ugzuzg Ugzuzg marked this pull request as ready for review October 3, 2022 17:34
bidoubiwa
bidoubiwa suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great PR 🔥

Could you update the README.md as well? At the bottom their are the API references.
Also, could you update the tests in settings.test.ts by adding the faceting in the tests?

The styling tests are failing, could you check them ? yarn style:fix

@bidoubiwa
Copy link
Contributor

Also, could you update the tests in settings.test.ts by adding the faceting in the tests?

My bad this is already oke :)

bidoubiwa
bidoubiwa suggested changes Oct 4, 2022
View reviewed changes
@bidoubiwa bidoubiwa added the enhancement New feature or request label Oct 4, 2022
@Ugzuzg Ugzuzg requested a review from bidoubiwa October 4, 2022 15:15
bidoubiwa
bidoubiwa suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad I come with these late comments, I just noticed them

@bidoubiwa bidoubiwa mentioned this pull request Oct 4, 2022
Merged
3 tasks
bidoubiwa
bidoubiwa suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is only one thing missing, it's adding the new methods at the bottom of the README.md in the API references?

bidoubiwa
bidoubiwa reviewed Oct 4, 2022
View reviewed changes
.code-samples.meilisearch.yaml
settings_guide_faceting_1: |-
client.index('books').updateSettings({ faceting: { maxValuesPerFacet: 5 }})
client.index('movies').updateSettings({ faceting: { maxValuesPerFacet: 5 }})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for noticing this error 🙏

@Ugzuzg Ugzuzg requested a review from bidoubiwa October 4, 2022 16:07
bidoubiwa
bidoubiwa suggested changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add settings in the titles. But I understand it was intuitive to add them

@Ugzuzg Ugzuzg requested a review from bidoubiwa October 4, 2022 16:09
@bidoubiwa bidoubiwa mentioned this pull request Oct 4, 2022
Closed
bidoubiwa
bidoubiwa approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 Very nice PR thanks a lot

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Oct 4, 2022

Build succeeded:

@meili-bors meili-bors bot merged commit 3586193 into meilisearch:main Oct 4, 2022
@bidoubiwa
Copy link
Contributor

Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive a small gift from Meilisearch too, don't forget to fill this form.

@Ugzuzg Ugzuzg deleted the feat/faceting branch October 4, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the facet setting customization at the index level
2 participants
@Ugzuzg @bidoubiwa