Skip to content

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jul 6, 2022

As per this issue

  • Update update_a_key_1 PR
    • Only update name and description: "name": "Products/Reviews API key", "description": "Manage documents: Products/Reviews API key"
  • Update get_all_keys_1 PR
    • Update to add limit parameter: limit=3'
  • Update delete_a_key_1 PR
    • Replace key key with uid: 6062abda-a5aa-4414-ac91-ecd7944c0f8d
  • Update security_guide_update_key_1 PR
    • Replace key key with uid: 74c9c733-3368-4738-bbe5-1d18a5fecb37
    • Replace updating indexes with description: { "description": "Default Search API Key" }'
  • Update security_guide_delete_key_1 PR
    • Replace key key with uid: `ac5cd97d-5a4b-4226-a868-2d0eb6d197ab

A part:

  • Change the key of update_a_key and get_one_key from d0552b41536279a0ad88bd595327b96f01176a60c2243e906c52ac02375f9bc4 to 6062abda-a5aa-4414-ac91-ecd7944c0f8d

@bidoubiwa bidoubiwa requested review from brunoocasali and mdubus July 6, 2022 11:01
? PLEASE_UPDATE_ME>>>>>>>>>>>>>PLEASE_UPDATE_ME>>>>>>>>>>>>>getting_started_check_task_status
: |-
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My linter automatically saves to this. Please ignore :')

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you know you could interactively add chunks of code to the commit?

use git add -p

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it just after. Normally I do it but I completely forgot to do it

@bidoubiwa bidoubiwa force-pushed the update_keys_code_sample_v0.28.0 branch from 4151c86 to 25dec79 Compare July 6, 2022 11:05
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jul 6, 2022
@bidoubiwa bidoubiwa merged commit d01935f into meili-bot/code-samples-v0-28 Jul 6, 2022
@bidoubiwa bidoubiwa deleted the update_keys_code_sample_v0.28.0 branch July 6, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants