Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in exported type: RakingScoreDetails -> RankingScoreDetails #1569

Closed
derekperkins opened this issue Aug 21, 2023 · 2 comments · Fixed by #1571
Closed

Typo in exported type: RakingScoreDetails -> RankingScoreDetails #1569

derekperkins opened this issue Aug 21, 2023 · 2 comments · Fixed by #1571
Labels
bug Something isn't working

Comments

@derekperkins
Copy link

derekperkins commented Aug 21, 2023

export type RakingScoreDetails = {
  words?: {
    order: number
    matchingWords: number
    maxMatchingWords: number
    score: number
  }
  typo?: {
    order: number
    typoCount: number
    maxTypoCount: number
    score: number
  }
  proximity?: {
    order: number
    score: number
  }
  attribute?: {
    order: number
    attributes_ranking_order: number
    attributes_query_word_order: number
    score: number
  }
  exactness?: {
    order: number
    matchType: string
    score: number
  }
  [key: string]: Record<string, any> | undefined
}

https://github.com/meilisearch/meilisearch-js/blob/main/src/types/types.ts#L157C13-L157C31

@bidoubiwa
Copy link
Contributor

Hey @derekperkins

Thanks for raising this 🙏 If you have time to fix it, it would be great. We'll be able to publish it asap

@bidoubiwa bidoubiwa added the bug Something isn't working label Aug 22, 2023
tonyghouse added a commit to tonyghouse/meilisearch-js that referenced this issue Aug 22, 2023
@tonyghouse
Copy link
Contributor

fixed typo . @bidoubiwa take a look and suggest any changes if needed #1571

@meili-bors meili-bors bot closed this as completed in 25115c6 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants