status canceled is missing on TaskStatus type
#1560
Comments
3 tasks
nicolasvienot
changed the title
Canceled for TaskStatus is missingcanceled is missing on TaskStatus type
meili-bors bot
added a commit
that referenced
this issue
Aug 7, 2023
1561: fix(type): add canceled status to type TaskStatus r=atoulmet a=nicolasvienot # Pull Request ## Related issue Fixes #1560 ## What does this PR do? In Meilisearch `v0.30.0`, the feature `Cancel processing and enqueued tasks` [has been added](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0). By doing so, they added a task status `canceled`. It's documented [here](https://www.meilisearch.com/docs/reference/api/tasks#status). The status `canceled` is missing in the type `TaskStatus` in meilisearch-js. - Add `canceled` status to `TaskStatus` type - Update a test in the cancel part of the task tests ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: nicolasvienot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In Meilisearch
v0.30.0, the featureCancel processing and enqueued taskshas been added.By doing so, they added a task status
canceled.It's documented here.
The status
canceledis missing on theTaskStatustype on meilisearch-js.Expected behavior
TaskStatustype should containCanceledCurrent behavior
Error when using type
TaskStatusfrom outsideThe text was updated successfully, but these errors were encountered: