Skip to content

Commit

Permalink
Merge #1522
Browse files Browse the repository at this point in the history
1522: Change target in tsconfig to ES6 r=bidoubiwa a=bidoubiwa

By default, the target in a tsconfig is `ES3`. This ensures compatibility with environments that predates 2015. The downside of having this insurance is the size of the bundle.

By changing from `ES3` to `esnext` we go from a bundle size of 108k to a bundle size of 60k.

Looking at what other libraries do, they seem to agree on using `esnext` as a target. While you might argue that it raises some risks, our library, like the other ones using `esnext`, is made to be used in modern environments.


Co-authored-by: Charlotte Vermandel <[email protected]>
  • Loading branch information
meili-bors[bot] and bidoubiwa authored Jun 20, 2023
2 parents c610b4f + 21cb630 commit c919f08
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"compilerOptions": {
"module": "esnext",
"target": "ES6",
"noEmit": true,
"allowJs": false,
"removeComments": false,
Expand Down

0 comments on commit c919f08

Please sign in to comment.