Keep both _geo and _geoloc fields in hits and hits._formatted #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantsearch geo widget requires the geo field to be named
_geoloc. Nonetheless, the field returned from meilisearch is_geo.Previously we replaced
_geowith_geolocat the root of the hits (so not in_formatted) which in itself was a bug.Since
instantsearchneeds_geolocbut we also want to avoid confusing the user to why their_geofield disappeared, we decided to keep both_geoand_geolocfiles at the root of the hit but also in _formatted (of course only if there was a_geofield present to begin with).