Add beta pagination feature #798
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
the
breaking-change
bidoubiwa
force-pushed
the
pagination-beta
branch
from
0672474 to
7010569
Compare
bidoubiwa
commented
Jul 25, 2022
…isearch into pagination-beta
…isearch into pagination-beta
brunoocasali
reviewed
Aug 2, 2022
src/adapter/search-response-adapter/__tests__/pagination-adapter.tests.ts
Outdated
Show resolved
Hide resolved
| } else if (totalHits !== undefined) { | ||
| return totalHits | ||
| } | ||
| return hitsPerPage * totalPages |
Member
There was a problem hiding this comment.
According to our internal conversation, this will change in the future, right @bidoubiwa ?
Contributor
Author
There was a problem hiding this comment.
According to our internal conversation, this will change in the future,
What do you mean?
Member
There was a problem hiding this comment.
The idea here is that the core team provides a real number of hits we have. Because even we doing a math here we cannot be 100% sure since we may have pages without the whole limit.
Contributor
Author
There was a problem hiding this comment.
Its the if just above
else if (totalHits !== undefined) {
return totalHits
}
Thats the hit Meilisearch returns. The return is a safe guard in case total hits is missing but it should indeed not happen so I could as well remove it
Contributor
Author
|
It has been implemented in #878 and released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like users to be able to test out our new way to handle pagination before adding it to Meilisearch.
While previously if the user wanted to have a pagination with page number (Ex:
<< < 1, 2, 3, ... > >>) they had to usefinitePagination:trueandpaginationTotalHits.These have been removed as Meilisearch now handles this type of pagination.
The following parameters in the
instantMeiliSearchclient are removed:finitePaginationpaginationTotalHitsSee related issue
See related discussion