Pass client agent to meilisearch-js #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Jun 29, 2022
Base automatically changed from
update_variable_names_v0.28
to
bump-meilisearch-v0.28.0
June 30, 2022 09:32
curquiza
reviewed
Jun 30, 2022
curquiza
requested changes
Jun 30, 2022
bidoubiwa
force-pushed
the
add_client_agents
branch
from
e27494b to
154d9ef
Compare
curquiza
approved these changes
Jun 30, 2022
brunoocasali
approved these changes
Jun 30, 2022
20 tasks
bidoubiwa
added a commit
that referenced
this pull request
Jul 11, 2022
* Update search route request and response parameters naming v0.28.x * Pass client agent to meilisearch-js * Improve check release script * Use double quotes on string with no dynamic variable in check releases script * Add missing whitespace in check-release.sh * Add possibility to provide client agents through the parameters of instantMeilisearch * Fix search resolver tests Co-authored-by: Charlotte Vermandel <[email protected]>
meili-bors bot
added a commit
that referenced
this pull request
Jul 12, 2022
791: Update version for the next release (v0.8.0) r=bidoubiwa a=bidoubiwa This version makes this package compatible with Meilisearch v0.28.0 🎉 Check out the changelog of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) for more information on the changes. ## 💥 Breaking changes - `facetsDistribution` search request parameter was renamed to `facets` causing a throw when using this package version with a version of Meilisearch prior to [`v0.28.0rcX`](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0rc1). #779 - This release is only compatible with the latest version of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) ## 🚀 Enhancements - Pass client agent to meilisearch-js #780 Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection) Also, of course, every analytics data we collect are ANONYMOUS [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html). Thanks again to `@bidoubiwa` ! 🎉 Co-authored-by: Charlotte Vermandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See related issue
This PR passes down the information of the instant-meilisearch package to the meilisearch-js package which in turn provided the information to meilisearch.