Remove histPerPage and rename limitPerRequest into paginationTotalResults #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
added
the
breaking-change
Closed
curquiza
force-pushed
the
rename-limitperrequest
branch
from
9b191ea to
398327c
Compare
curquiza
force-pushed
the
rename-limitperrequest
branch
from
4120f76 to
1630657
Compare
curquiza
force-pushed
the
rename-limitperrequest
branch
from
1630657 to
c872b43
Compare
curquiza
changed the title
curquiza
changed the title
bidoubiwa
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why rename
limitPerRequest? Because of the confusion: it's not a limit per request but the total (and finite) number of results you can browse during pagination. It fixes partially the confusion in #18.Why remove
hitsPerPage? Because we can already configure it withInstantSearch.configurefunction and our parameter would be redundant.