Skip to content

Conversation

@curquiza
Copy link
Member

@curquiza curquiza commented Aug 6, 2020

Fix this #18 (comment).
The change is not visible because I add the react playground at the same time.
I replace:

 <Pagination />

by

 <Pagination showLast={true} />

I don't know if it fixes the complete issue yet (waiting for the author's answer).

Plus: Add a React Playground

NB about the React Playground:

  • playgrounds/react/src/instant-meilisearch.js is a soft link, otherwise react-add does not want to start (it can not import files outside of the src folder by default)
  • SKIP_PREFLIGHT_CHECK=true in the .env file allows the app to start even if the version of jest-babel is not the same in the React playground and in the main app (at the root of the repo)

@curquiza curquiza requested a review from bidoubiwa August 6, 2020 15:04
@curquiza curquiza changed the title Pagination issue in React Pagination issue in React and add React playground Aug 6, 2020
@curquiza curquiza mentioned this pull request Aug 10, 2020
@bidoubiwa
Copy link
Contributor

bidoubiwa commented Aug 10, 2020

I think they might still be a problem with the pagination. When I type war and go rapidly from page 6 to 7 and 7 to 6. The pages sometimes needs to refresh completely and then ignores my change.

I'm not sure this is an important bug but still letting you know

EDIT:
Sometimes, for a fraction of second when I click on 7 it will highlight 5.

@curquiza
Copy link
Member Author

What do you mean by "ignores your changes"?

@curquiza curquiza requested a review from bidoubiwa August 10, 2020 13:37
@curquiza
Copy link
Member Author

@bidoubiwa
Copy link
Contributor

@curquiza Yes !

@curquiza
Copy link
Member Author

Hope this is not annoying for our users...

@curquiza curquiza merged commit 43df64e into master Aug 10, 2020
@curquiza curquiza deleted the pagination-issue branch August 10, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants