Skip to content

Conversation

@GoryMoon
Copy link
Contributor

Pull Request

What does this PR do?

Fixes #325

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @GoryMoon for this PR!
Very nice work 🎉 I just had a suggestion. Thanks to contribute to Meilisearch ❤️

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✨

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 25, 2022

@bors bors bot merged commit 9236b8f into meilisearch:main Jul 25, 2022
@GoryMoon GoryMoon deleted the 325-support-pagination-setting branch July 25, 2022 09:14
@alallema alallema added the enhancement New feature or request label Jul 25, 2022
bors bot added a commit that referenced this pull request Jul 26, 2022
330: Add pagination setting code samples and fix code sample typos r=alallema a=GoryMoon

Based on the comments from #329 this adds code samples for the pagination settings added in #328.

It also includes some typo fixes from the additions in #294.


Co-authored-by: GoryMoon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to the pagination setting customization at the index level

2 participants