Skip to content

Conversation

@brunoocasali
Copy link
Member

Since the adoption of this new release system *(now we need to update the version of the constant defined in the version.go file). We now need to validate that we are following this step.

Related to #279

@brunoocasali brunoocasali requested a review from alallema April 2, 2022 23:01
@brunoocasali brunoocasali changed the base branch from main to feature/add-user-agent-header April 2, 2022 23:02
alallema
alallema previously approved these changes Apr 4, 2022
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done for the script 🌯

@brunoocasali brunoocasali force-pushed the feature/add-user-agent-header branch from 3dcdcb4 to c54697b Compare April 4, 2022 14:47
@brunoocasali brunoocasali force-pushed the add-steps-to-release branch from 7ef9b5f to dd9c83a Compare April 5, 2022 16:36
@brunoocasali
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Apr 5, 2022
@bors
Copy link
Contributor

bors bot commented Apr 5, 2022

try

Build failed:

Base automatically changed from feature/add-user-agent-header to main April 5, 2022 17:33
@alallema
Copy link
Contributor

alallema commented Apr 5, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 5, 2022

@bors bors bot merged commit 95ff018 into main Apr 5, 2022
@bors bors bot deleted the add-steps-to-release branch April 5, 2022 17:48
@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants