Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up syntax of Test project #611

Merged
merged 1 commit into from
Jan 15, 2025
Merged

clean up syntax of Test project #611

merged 1 commit into from
Jan 15, 2025

Conversation

danFbach
Copy link
Contributor

Pull Request

What does this PR do?

  • removes unused usings.
  • removes unused fields.
  • corrects IDE suggestions.
  • adds ignores for '_' properties.
  • all tests continue to pass.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@danFbach
removes unused usings.
1cfb097 
removes unused fields.
corrects IDE suggestions.
adds ignores for '_' properties.
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Jan 15, 2025
curquiza
curquiza reviewed Jan 15, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank youuu

bors merge

curquiza
curquiza approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 15, 2025

Already running a review

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 15, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit fd0b4d2 into meilisearch:main Jan 15, 2025
4 checks passed
@danFbach danFbach deleted the test-syntax-cleanup branch January 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danFbach @curquiza