Skip to content

Possible fix to release issue #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

danFbach
Copy link
Contributor

@danFbach danFbach commented Jan 13, 2025

Pull Request

Related issue

Fixes #605

What does this PR do?

  • removes unused System.Globalization using. this may be the fix for the issue - this is more/less a guess since i can't test the publish on my end.
  • while reviewing this file, i noticed that the type matching could be accomplished more easily by using built-in pattern type matching instead of reflection based type matching, also making code more readable. All tests passed.

Hope this helps!

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

use pattern type matching instead of reflection based type matching, making code more readable.
@danFbach
Copy link
Contributor Author

danFbach commented Jan 13, 2025

hey @curquiza
Can you review this? might allow us to release v1.16

Perhaps we try to remove the changes to publish.yml to make sure this is the fix and the additional code in publish.yml is unnecessary?

@danFbach
Copy link
Contributor Author

after some review, the using System.Globalization; line was introduced Dec 2 2022 so this may not be a fix. these changes are probably good for the codebase, anyway.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank youuu, let's try it!

bors merge

Copy link
Contributor

meili-bors bot commented Jan 15, 2025

Build succeeded:

@danFbach danFbach closed this Jan 15, 2025
@meili-bors meili-bors bot merged commit c6810ca into meilisearch:main Jan 15, 2025
4 checks passed
@curquiza curquiza added the bug Something isn't working label Jan 15, 2025
@danFbach danFbach deleted the possible-publish-fix branch January 21, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible to release the package to Nugget
2 participants