Skip to content

Conversation

@meili-bot
Copy link
Contributor

This PR gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:

  • the next release of Meilisearch (v0.28.0) is out.
  • the meilisearch-js dependency has been released to be compatible with Meilisearch v0.28.0.
    Once the release is out, the upgrade of the meilisearch-js dependency might be committed to this branch.

This PR is auto-generated for the pre-release week purpose.

Related to this issue: meilisearch/integration-guides#205

@meili-bot meili-bot added the skip-changelog The PR will not appear in the release changelogs label Jun 9, 2022
@bidoubiwa bidoubiwa requested review from brunoocasali and mdubus July 12, 2022 09:19
@bidoubiwa bidoubiwa marked this pull request as ready for review July 12, 2022 09:20
mdubus
mdubus previously approved these changes Jul 12, 2022
@bidoubiwa
Copy link
Contributor

bors merge

meili-bors bot added a commit that referenced this pull request Jul 12, 2022
139: Changes related to the next Meilisearch release (v0.28.0) r=bidoubiwa a=meili-bot

This PR gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:
  - the next release of Meilisearch (v0.28.0) is out.
  - the [`meilisearch-js`](https://github.com/meilisearch/meilisearch-js) dependency has been released to be compatible with Meilisearch v0.28.0.
  Once the release is out, the upgrade of the `meilisearch-js` dependency might be committed to this branch.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

_Related to this issue: https://github.com/meilisearch/integration-guides/issues/205_


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 12, 2022

Timed out.

mdubus
mdubus previously approved these changes Jul 12, 2022
mdubus
mdubus previously approved these changes Jul 12, 2022
@bidoubiwa
Copy link
Contributor

bors merge

meili-bors bot added a commit that referenced this pull request Jul 18, 2022
139: Changes related to the next Meilisearch release (v0.28.0) r=bidoubiwa a=meili-bot

This PR gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:
  - the next release of Meilisearch (v0.28.0) is out.
  - the [`meilisearch-js`](https://github.com/meilisearch/meilisearch-js) dependency has been released to be compatible with Meilisearch v0.28.0.
  Once the release is out, the upgrade of the `meilisearch-js` dependency might be committed to this branch.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

_Related to this issue: https://github.com/meilisearch/integration-guides/issues/205_


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 18, 2022

Timed out.

@brunoocasali
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Jul 18, 2022
139: Changes related to the next Meilisearch release (v0.28.0) r=brunoocasali a=meili-bot

This PR gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:
  - the next release of Meilisearch (v0.28.0) is out.
  - the [`meilisearch-js`](https://github.com/meilisearch/meilisearch-js) dependency has been released to be compatible with Meilisearch v0.28.0.
  Once the release is out, the upgrade of the `meilisearch-js` dependency might be committed to this branch.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

_Related to this issue: https://github.com/meilisearch/integration-guides/issues/205_


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 18, 2022

Timed out.

@brunoocasali
Copy link
Member

bors merge

meili-bors bot added a commit that referenced this pull request Jul 19, 2022
139: Changes related to the next Meilisearch release (v0.28.0) r=brunoocasali a=meili-bot

This PR gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:
  - the next release of Meilisearch (v0.28.0) is out.
  - the [`meilisearch-js`](https://github.com/meilisearch/meilisearch-js) dependency has been released to be compatible with Meilisearch v0.28.0.
  Once the release is out, the upgrade of the `meilisearch-js` dependency might be committed to this branch.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

_Related to this issue: https://github.com/meilisearch/integration-guides/issues/205_


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 19, 2022

Timed out.

@bidoubiwa
Copy link
Contributor

bors merge

meili-bors bot added a commit that referenced this pull request Jul 19, 2022
139: Changes related to the next Meilisearch release (v0.28.0) r=bidoubiwa a=meili-bot

This PR gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.

⚠️ This PR should NOT be merged until:
  - the next release of Meilisearch (v0.28.0) is out.
  - the [`meilisearch-js`](https://github.com/meilisearch/meilisearch-js) dependency has been released to be compatible with Meilisearch v0.28.0.
  Once the release is out, the upgrade of the `meilisearch-js` dependency might be committed to this branch.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

_Related to this issue: https://github.com/meilisearch/integration-guides/issues/205_


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Charlotte Vermandel <[email protected]>
Co-authored-by: cvermand <[email protected]>
@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 19, 2022

Timed out.

@bidoubiwa
Copy link
Contributor

For some reason the tests are timing out on the github CI but not on my local env. I'm trying to figure out why

mdubus
mdubus previously approved these changes Jul 19, 2022
uses: actions/checkout@v3
- name: Setup node
uses: actions/setup-node@v1
uses: actions/setup-node@v2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you use v2 here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests stopped working when passing on v3. It is on my todo list to update all github-actions on every repository I maintain. I will make the changes at that moment

@bidoubiwa bidoubiwa requested review from bidoubiwa and mdubus July 20, 2022 12:19
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 20, 2022

@meili-bors meili-bors bot merged commit 1f25817 into main Jul 20, 2022
@meili-bors meili-bors bot deleted the bump-meilisearch-v0.28.0 branch July 20, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants