Remove unecessary node download during github actions #273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the github action
actions/setup-node@v1
regularly timeout ( multiple times in the last few months [1][2])And since latest version of node is builtin with the OS our github actions uses (search for
Node
here):I completely removed
actions/setup-node@v1
from our g/a. Which was really useful in the case you need a specific version of node. We do not need an older version of node and we should keep up with node latest release.Other possibility would be to run a node container with the version we want: