Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unecessary node download during github actions #273

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Apr 6, 2020

Since the github action actions/setup-node@v1 regularly timeout ( multiple times in the last few months [1][2])

Screenshot 2020-04-06 at 17 13 41

15 min before timeout on this C/I

And since latest version of node is builtin with the OS our github actions uses (search for Node here):

runs-on: ubuntu-18.04

I completely removed actions/setup-node@v1 from our g/a. Which was really useful in the case you need a specific version of node. We do not need an older version of node and we should keep up with node latest release.

Other possibility would be to run a node container with the version we want:

your_job:
  runs-on: ubuntu-latest
  container: node:10.9

@bidoubiwa bidoubiwa requested review from tpayet and curquiza April 6, 2020 15:14
@bidoubiwa bidoubiwa merged commit a742080 into master Apr 6, 2020
@bidoubiwa bidoubiwa deleted the remove_node_from_ga branch April 6, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants