Skip to content

Conversation

@maryamsulemani97
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 commented May 11, 2023

closes #2411 and #1591

For reviewers

To avoid confusion over which route to use GET /indexes/{index_uid}/documents vs POST /indexes/{index_uid}/documents/fetch and delete by batch vs delete by filter, I added a warning for GET /indexes/{index_uid}/documents and delete by batch saying they will be deprecated in the near future.

@maryamsulemani97 maryamsulemani97 marked this pull request as ready for review May 16, 2023 12:46
@maryamsulemani97 maryamsulemani97 requested a review from a team as a code owner May 16, 2023 12:46
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor additional comments on top of the open discussions.

More importantly, there have been changes to the spec concerning error messages when using the new endpoints. @maryamsulemani97, can you update this PR to reflect those changes?

Issue 3774 on the engine repo seems to summarise everything.

Copy link
Contributor

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we document these two new usage of the filters at the beginning of this page: https://www.meilisearch.com/docs/learn/advanced/filtering

Filters have several use-cases, such as refining search results and creating faceted search interfaces. Faceted search interfaces are particularly efficient in helping users navigate a great number of results across many broad categories.

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-samples are approved 👌

@bidoubiwa bidoubiwa self-requested a review May 30, 2023 13:07
@bidoubiwa bidoubiwa self-requested a review May 30, 2023 13:25
@maryamsulemani97 maryamsulemani97 requested a review from macraig May 30, 2023 13:53
Copy link
Contributor

@macraig macraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@maryamsulemani97 maryamsulemani97 removed their assignment May 31, 2023
@maryamsulemani97 maryamsulemani97 merged commit 1af6bbb into v1.2 Jun 1, 2023
@maryamsulemani97 maryamsulemani97 deleted the Delete-and-get-documents-by-filter branch June 1, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.2: Delete and get documents by filter Change document id to document ID

6 participants