-
Notifications
You must be signed in to change notification settings - Fork 268
v1.2: Delete and get documents by filter #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: gui machiavelli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor additional comments on top of the open discussions.
More importantly, there have been changes to the spec concerning error messages when using the new endpoints. @maryamsulemani97, can you update this PR to reflect those changes?
Issue 3774 on the engine repo seems to summarise everything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we document these two new usage of the filters at the beginning of this page: https://www.meilisearch.com/docs/learn/advanced/filtering
Filters have several use-cases, such as refining search results and creating faceted search interfaces. Faceted search interfaces are particularly efficient in helping users navigate a great number of results across many broad categories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-samples are approved 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
closes #2411 and #1591
For reviewers
To avoid confusion over which route to use GET
/indexes/{index_uid}/documentsvs POST/indexes/{index_uid}/documents/fetchand delete by batch vs delete by filter, I added a warning for GET/indexes/{index_uid}/documentsand delete by batch saying they will be deprecated in the near future.