Skip to content

Conversation

dichotommy
Copy link
Contributor

@dichotommy dichotommy commented Jun 15, 2022

Update language and tokenization pages for v0.28. Related to #1688

@dichotommy dichotommy changed the base branch from master to v0.28 June 15, 2022 08:54
Also reduce technical complexity of language page (no need to mention specific normalizers + segmenters)
@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 15, 2022
@guimachiavelli guimachiavelli linked an issue Jun 21, 2022 that may be closed by this pull request
@guimachiavelli
Copy link
Member

Is this ready for review? If not, what are we missing?

@dichotommy dichotommy marked this pull request as ready for review June 23, 2022 13:28
Copy link
Member

@guimachiavelli guimachiavelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I will request an SME review once the programmer responsible for this returns from his holidays.

@maryamsulemani97 maryamsulemani97 self-assigned this Jul 5, 2022
@guimachiavelli guimachiavelli merged commit d880d3b into v0.28 Jul 7, 2022
@guimachiavelli guimachiavelli deleted the v0.28-hebrew-tokenizer branch July 7, 2022 13:24
bors bot added a commit that referenced this pull request Jul 7, 2022
1769: v0.28: Update "create issue" link r=guimachiavelli a=guimachiavelli

As requested on #1728 (comment)

Co-authored-by: gui machiavelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v0.28: Hebrew language support

5 participants