-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for waveorder==1.0.0
release
#114
Conversation
Here are the scripts we don't need to maintain in this repo:
Here are the scripts/docs we should maintain:
I'll generate a few PDFs, so you can see where they fit well. I suggest we update them with every release.
Are you thinking of running these examples via pytest? That's an interesting idea and will allow us to test refactors. We should discuss offline which of the tests should be run during CI and which should be run manually before release. |
@edyoshikun can you help with moving the multiProcessing scripts to recOrder? |
I think we should only have 1 example for the multiprocessing on the recOrder side since the codebase is the same. The current example from @talonchandler here is a great example and the slurm scripts can serve as compliment slurm scripts PR. Also from the testing and future development and refactoring perspective, we agree it is easier to mantain. |
This PR is ready for review. After discussing with @mattersoflight and looking closely at all of the examples, I partitioned the examples into two sets:
@edyoshikun I agree that the multiprocessing example in I'm very open to suggestions. Does the folder structure makes sense (I'm hoping the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reorganization. Looks great!
I am grouping our remaining tasks to prepare for
1.0.0
into this PR. Please feel free to edit or suggest additional tasks.WaveorderReader
,WaveorderWriter
and associated tests fromwaveorder
transition the maintained example scripts toand testiohub
waveorder 1.0.0
This PR needs to merge before
alg-dev
merges.