Don't delete test data? #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview page for your plugin is ready here: |
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 11.14% 11.08% -0.06%
==========================================
Files 44 44
Lines 5969 5965 -4
==========================================
- Hits 665 661 -4
Misses 5304 5304
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ieivanov
approved these changes
Aug 29, 2022
|
Good call. I just made a matched PR in waveorder: mehta-lab/waveorder#83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ieivanov I owe an apology for deleting these lines a few months ago without much announcement, then you were likely confused and had to reintroduce them.
I'm suggesting deleting them again because I would like to run new/modified tests locally without waiting for the test data to download.
I'm suggesting that we keep the test data, but you may have a better solution. Is there a reason to delete them? I don't think GitHub actions complains? Is there a different workflow that you use to quickly iterate and rerun the tests without waiting for a complete download?