-
Notifications
You must be signed in to change notification settings - Fork 2
Person A implementation #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,37 @@ | ||
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| *.local | ||
|
|
||
| # Environment variables | ||
| .env | ||
| .env.local | ||
|
|
||
| # Tests | ||
| tests/ | ||
| vitest.config.js | ||
| TEST_*.md | ||
| TESTING_*.md | ||
|
|
||
| # Editor directories and files | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? | ||
|
Comment on lines
+1
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove duplicate ignore patterns. The newly added section (lines 1-34) contains numerous patterns that already exist in the organized section below (lines 35-172):
While duplicate patterns don't break functionality, they create maintenance burden and confusion. 🧹 Recommended cleanupRemove the duplicate section (lines 1-34) and rely on the existing well-organized patterns (lines 35-172). If any patterns in lines 1-34 are truly unique (e.g., 🤖 Prompt for AI Agents |
||
| # ═══════════════════════════════════════════════════════════════════ | ||
| # NEXUS — .gitignore | ||
| # Place this file at the repo ROOT: nexus/.gitignore | ||
|
|
@@ -135,4 +169,4 @@ logs/ | |
|
|
||
| *.so | ||
| *.dylib | ||
| *.dll | ||
| *.dll | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
|
|
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignoring the entire
tests/directory prevents committing test files.Line 20 ignores the entire
tests/directory. This pattern will exclude all test source files from version control, which is almost certainly incorrect. Test code should be committed to the repository.If the intent is to ignore test artifacts or coverage reports, use more specific patterns like:
tests/__pycache__/(already covered by line 61)tests/.pytest_cache/(already covered by line 76)tests/coverage/tests/output/🧪 Recommended fix
Note:
vitest.config.jsshould also be committed as it's a configuration file (see separate comment).🤖 Prompt for AI Agents