chore(e2e): Skip vite-isolation-context-sandbox on node14

megahertz · Dec 30, 2023 · f1844e0 · f1844e0
1 parent 9dcfda7
commit f1844e0
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/e2e/E2eApp.js b/e2e/E2eApp.js
@@ -26,10 +26,18 @@ class E2eApp {
     return Number.parseInt(electronPackageJson.version, 10);
   }
 
+  get nodeVersion() {
+    return Number.parseInt(process.version.replace('v', ''), 10);
+  }
+
   isSupportEsm() {
     return this.electronVersion >= 28;
   }
 
+  log(...args) {
+    console.info('E2E:', ...args); // eslint-disable-line no-console
+  }
+
   async run({ clearLogs = true } = {}) {
     if (clearLogs) {
       await this.removeLogDir();
@@ -91,6 +99,8 @@ class E2eApp {
           .replace(/^Fontconfig.*$/mg, '')
           .replace(/^.*Desktop Identity.*$/mg, '')
           .replace(/^.*Gtk-WARNING.*$/mg, '')
+          .replace(/^.*bus.cc.*$/mg, '')
+          .replace(/^.*viz_main_impl.cc.*$/mg, '')
           .replace(/^\n/mg, '');
 
         // eslint-disable-next-line no-console

diff --git a/e2e/esbuild-esm/main.spec.cjs b/e2e/esbuild-esm/main.spec.cjs
@@ -7,7 +7,7 @@ const app = new E2eApp({ appPath: __dirname });
 
 test(app.appName, async () => {
   if (!app.isSupportEsm()) {
-    console.info(`Skipping ESM test for Electron ${app.electronVersion}`);
+    app.log(`Skipping ESM test for Electron ${app.electronVersion}`);
     return;
   }
 
@@ -17,7 +17,3 @@ test(app.appName, async () => {
     'log from renderer',
   ]);
 }, app.timeout);
-
-function electronSupportsEsm() {
-
-}
diff --git a/e2e/vite-isolation-context-sandbox/main.spec.js b/e2e/vite-isolation-context-sandbox/main.spec.js
@@ -6,6 +6,11 @@ const E2eApp = require('../E2eApp');
 const app = new E2eApp({ appPath: __dirname });
 
 test(app.appName, async () => {
+  if (app.nodeVersion < 16) {
+    app.log('Skipping because Vite requires Node 16 for this test');
+    return;
+  }
+
   const logReader = await app.run();
   expect(logReader.format()).toEqual([
     'log from the main process',