Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the document and json scheme #346

Merged
merged 7 commits into from
May 8, 2023
Merged

Correct the document and json scheme #346

merged 7 commits into from
May 8, 2023

Conversation

haoel
Copy link
Contributor

@haoel haoel commented May 6, 2023

  • Correct the channel example
  • To disable the PID file, support configure the - (keep the same behavior linke SLA data)
  • Add how to disable the SLA data in JSON scheme.

close #344 and #345

@haoel haoel changed the title Correct the channel example Correct the document and json scheme May 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9ff1722) 99.68% compared to head (c398b53) 99.68%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          83       83           
  Lines        5671     5671           
=======================================
  Hits         5653     5653           
  Misses         12       12           
  Partials        6        6           
Impacted Files Coverage Δ
conf/conf.go 97.06% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

docs/Manual.md Outdated Show resolved Hide resolved
docs/Manual.md Outdated Show resolved Hide resolved
@haoel haoel requested a review from oewang May 7, 2023 03:16
@haoel haoel added this pull request to the merge queue May 8, 2023
Merged via the queue into megaease:main with commit 866c6f4 May 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questions about the Channel example in the user manual title 4
4 participants