Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using retry loop to remove the temp dir #228

Merged
merged 1 commit into from
Oct 11, 2022
Merged

using retry loop to remove the temp dir #228

merged 1 commit into from
Oct 11, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Oct 11, 2022

refer to golang/go#51442

@haoel haoel requested a review from samanhappy October 11, 2022 04:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 99.76% // Head: 99.64% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (308172b) compared to base (1f8465b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   99.76%   99.64%   -0.12%     
==========================================
  Files          70       72       +2     
  Lines        5064     5083      +19     
==========================================
+ Hits         5052     5065      +13     
- Misses          8       12       +4     
- Partials        4        6       +2     
Impacted Files Coverage Δ
notify/log/log_windows.go 100.00% <0.00%> (ø)
daemon/daemon_windows.go 50.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@haoel haoel merged commit 26c1c31 into megaease:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants