Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a command to generate JSON Schema #213

Merged
merged 11 commits into from
Sep 13, 2022
Merged

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Sep 8, 2022

The JSON Schema could help to edit the EaseProbe's configuration YAML file easier - we can use it to generate the UI form on the Web or just edit the YAML file via IDE like VSCode or Intellij IDEA.

This PR just generates the EaseProbe YAML Configuration JSON Schema

  • Support -j flag to generate the EaseProbe JSON Schema file.
  • The generated scheme file is uploaded to resources/schema.json

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Base: 99.71% // Head: 99.83% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (1f4e28a) compared to base (0108e6f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   99.71%   99.83%   +0.12%     
==========================================
  Files          70       67       -3     
  Lines        4975     4977       +2     
==========================================
+ Hits         4961     4969       +8     
+ Misses          9        5       -4     
+ Partials        5        3       -2     
Impacted Files Coverage Δ
conf/log.go 100.00% <ø> (ø)
eval/eval.go 100.00% <ø> (ø)
global/global.go 100.00% <ø> (ø)
notify/aws/conf.go 100.00% <ø> (ø)
notify/base/base.go 100.00% <ø> (ø)
notify/dingtalk/dingtalk.go 100.00% <ø> (ø)
notify/discord/discord.go 100.00% <ø> (ø)
notify/email/email.go 100.00% <ø> (ø)
notify/lark/lark.go 100.00% <ø> (ø)
notify/log/log.go 100.00% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

conf/conf.go Outdated Show resolved Hide resolved
notify/log/log.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/Manual.md Outdated Show resolved Hide resolved
docs/Manual.md Outdated Show resolved Hide resolved
docs/Manual.md Outdated Show resolved Hide resolved
Co-authored-by: Pantelis Roditis <[email protected]>
docs/Manual.md Outdated Show resolved Hide resolved
Co-authored-by: Pantelis Roditis <[email protected]>
@zhao-kun zhao-kun merged commit 6c3c65f into megaease:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants