Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom host header #198

Merged
merged 1 commit into from
Aug 22, 2022
Merged

custom host header #198

merged 1 commit into from
Aug 22, 2022

Conversation

xiaomao87
Copy link
Contributor

  • https://pkg.go.dev/net/http#Request

    // For client requests, Host optionally overrides the Host
    // header to send. If empty, the Request.Write method uses
    // the value of URL.Host. Host may contain an international
    // domain name.
    Host string

@codecov-commenter
Copy link

Codecov Report

Base: 99.41% // Head: 99.48% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (9e3f151) compared to base (b4a691d).
Patch coverage: 40.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #198      +/-   ##
==========================================
+ Coverage   99.41%   99.48%   +0.07%     
==========================================
  Files          49       47       -2     
  Lines        4085     4073      -12     
==========================================
- Hits         4061     4052       -9     
+ Misses         15       12       -3     
  Partials        9        9              
Impacted Files Coverage Δ
probe/http/http.go 96.58% <40.00%> (-1.44%) ⬇️
daemon/daemon_linux.go
daemon/daemon_windows.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

probe/http/http.go Outdated Show resolved Hide resolved
 * https://pkg.go.dev/net/http#Request

	// For client requests, Host optionally overrides the Host
	// header to send. If empty, the Request.Write method uses
	// the value of URL.Host. Host may contain an international
	// domain name.
	Host string
Copy link
Contributor

@haoel haoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR

@haoel haoel merged commit 882a021 into megaease:main Aug 22, 2022
@xiaomao87 xiaomao87 deleted the custom-host-header branch August 30, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants