Add some privatekey password options #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll change it again |
haoel
requested changes
Jul 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 93.89% 93.92% +0.03%
==========================================
Files 46 46
Lines 3636 3655 +19
==========================================
+ Hits 3414 3433 +19
Misses 155 155
Partials 67 67
Continue to review full report at Codecov.
|
|
One more thing, can you add the unit test case for this new feature? Thanks in advance! @zhangjunjie6b |
haoel
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide password configuration of privatekey