Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support regexp output check for http/shell/ssh probe #169

Merged
merged 4 commits into from
Jul 18, 2022

Conversation

haoel
Copy link
Contributor

@haoel haoel commented Jul 15, 2022

  • add an options regex:true|false to indicate the contain and not_contain is regexp or not.
  • create a TextChecker object to dedicate the checker configuration and logic
  • embed the TextChecker into HTTP/Shell/SSH probe

@haoel haoel requested review from proditis and zhao-kun July 15, 2022 14:16
Copy link
Collaborator

@proditis proditis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested

Adding the link here so that i can include details about the syntax on the extended documentation i'll work on https://github.com/google/re2/wiki/Syntax

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #169 (4fcb696) into main (8b5be29) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   93.15%   93.43%   +0.27%     
==========================================
  Files          46       46              
  Lines        3362     3411      +49     
==========================================
+ Hits         3132     3187      +55     
+ Misses        161      157       -4     
+ Partials       69       67       -2     
Impacted Files Coverage Δ
probe/common.go 100.00% <100.00%> (ø)
probe/http/http.go 97.63% <100.00%> (+0.07%) ⬆️
probe/shell/shell.go 100.00% <100.00%> (ø)
probe/ssh/ssh.go 89.37% <100.00%> (+4.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b5be29...4fcb696. Read the comment docs.

@haoel haoel merged commit 8a4de80 into megaease:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants