feat: Support time zone configuration #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
==========================================
+ Coverage 92.22% 92.27% +0.04%
==========================================
Files 46 46
Lines 3344 3364 +20
==========================================
+ Hits 3084 3104 +20
Misses 191 191
Partials 69 69
Continue to review full report at Codecov.
|
localvar
approved these changes
Jul 11, 2022
zhao-kun
reviewed
Jul 11, 2022
| @@ -128,11 +128,11 @@ func ToHTML(r probe.Result) string { | |||
| <td class="data">%s</td> | |||
| </tr> | |||
| </table> | |||
| ` + HTMLFooter(r.StartTime.Format(r.TimeFormat)) | |||
| ` + HTMLFooter(FormatTime(r.StartTime)) | |||
There was a problem hiding this comment.
A quick question: Who should take the responsibility for rendering the the time on the web page? the server or the client? It has a little different from other notifiers.
There was a problem hiding this comment.
currently, the web server renders the whole web page including the time.
zhao-kun
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #166
support the timezone configuration
Code changes:
timeformatfrom probe result to global package.TimeFormat()function