-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add HTTP Probe trace time metrics #150
Conversation
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 90.92% 92.18% +1.25%
==========================================
Files 44 45 +1
Lines 3020 3197 +177
==========================================
+ Hits 2746 2947 +201
+ Misses 203 185 -18
+ Partials 71 65 -6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed working as advertised 😄
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the README for the new feature.
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the following tracing metrics have been added:
dnsStartAt()
todnsDone()
connectStart()
toconnectDone()
tlsStart()
totlsDone()
wroteHeaderField()
towroteHeaders()
wroteRequest()
togotFirstResponseByte()
gotFirstResponseByte()
toputIdleConn()
getConn()
toputIdleConn()
it can be seen in Prometheus and Grafana, the following snapshot is an example.
open the debug log, you will see the following debug information