Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove probes with fail config #137

Merged
merged 6 commits into from
Jun 9, 2022

Conversation

proditis
Copy link
Collaborator

@proditis proditis commented Jun 9, 2022

This PR introduces the following changes

  • Display a clear error message when an unknown client driver is used
  • Remove probers that are not configured properly, from probers[]
  • Remove notifies that are not configured properly, from notifies[]
  • Error out and (exit?) when there are no probers or notifies configured
  • Update test cases to test for empty probers and notifies
  • Update test case for config to use port 65535 instead of the more common 8080 to avoid conflicts with local development environments

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #137 (89c9a8a) into main (1db0629) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   91.40%   91.41%           
=======================================
  Files          43       43           
  Lines        2920     2923    +3     
=======================================
+ Hits         2669     2672    +3     
  Misses        180      180           
  Partials       71       71           
Impacted Files Coverage Δ
probe/client/client.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db0629...89c9a8a. Read the comment docs.

@proditis proditis marked this pull request as ready for review June 9, 2022 10:00
@proditis proditis requested a review from haoel June 9, 2022 11:40
Copy link
Contributor

@haoel haoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haoel haoel merged commit d676381 into megaease:main Jun 9, 2022
@proditis proditis deleted the remove-probes-with-fail-config branch June 27, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants