Allow specifying endpoint url for S3 #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks like a useful addition. There's a couple of minor tweaks I'll make (e.g. the default for the parameter is |
|
thank you for the quick merge 🙏 |
|
Sorry for taking a while, your PR is in the latest 3.2.5 release available now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many services aside from AWS (for example Cloudflare R2) provide an S3 compatible interface, however the current implementation of the engine is restricted to Amazon. This simple patch allows for uploading to dozens of other hosts, as well as overriding the endpoint for AWS if necessary for e.g. GDPR compliance reasons.