Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font icons colors are edited programmatically #17

Merged
merged 6 commits into from
Apr 13, 2015

Conversation

abdelrahman-elkady
Copy link
Contributor

Editing font icons color using setTextColor(int color)

Editing font icons using setTextColor(int color)
@medyo
Copy link
Owner

medyo commented Apr 12, 2015

Looks cool 👍 , however it'll be more interesting if you could also add a new method to change icon color. In case of someone needs different color than TextColor. Can you handle that ?

@abdelrahman-elkady
Copy link
Contributor Author

for sure but will need more effort to handle the icons brought from resources (non font icons)

will do it btw even if not fully implemented , can be added on development branch

@medyo
Copy link
Owner

medyo commented Apr 12, 2015

Just ignore Icons from resources, just focus on Font Icons. the variables to check are
mIconResource and mIconPosition

@abdelrahman-elkady
Copy link
Contributor Author

you mean checking those variables for resource icons ?

Btw positioning will not make problems with icon color for the font icons I think

@medyo
Copy link
Owner

medyo commented Apr 12, 2015

I mean checking those variables just to know which type is used (from resource or font). Because applying color on a resource icon will not take any effect. You can follow that commit : 11c3290 to implement that new method setIconColor()

@abdelrahman-elkady
Copy link
Contributor Author

@medyo review the changes now

@medyo
Copy link
Owner

medyo commented Apr 13, 2015

Looks cool 👍 Thanks for your contribution

medyo added a commit that referenced this pull request Apr 13, 2015
Added new method to define icon color
@medyo medyo merged commit 5d2eed5 into medyo:master Apr 13, 2015
@abdelrahman-elkady abdelrahman-elkady deleted the changing-icon-color branch April 13, 2015 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants