Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Github requires authenticated channels only. #5

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2022

Github requires using authenticated channels whenever clonning a repo,
see: https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git

This change broke the luarocks installing script, since it was using unathenticated git:// protocol.

@ghost ghost self-requested a review as a code owner January 11, 2022 13:43
@alesr
Copy link

alesr commented Jan 11, 2022

Looks related since we use the same Alpine version: docker-library/php#1177

	https://github.blog/2021-09-01-improving-git-protocol-security-github/
	Github requires using authenticated channels whenever clonning a repo,
	see: https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git

	This change broke the `luarocks` installing script, since it was using unathenticated git:// protocol.
@m7moud m7moud force-pushed the git-protocol-security-github branch from 8c69ebc to 8415de3 Compare January 11, 2022 15:51
@m7moud m7moud merged commit 3e79204 into master Jan 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the git-protocol-security-github branch January 11, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants