-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(admin-ui): Inventory and order UI fixes and tweaks #3461
Merged
+68
−19
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
961ae7c
Small UI fixes and tweaks
StephixOne 5249d81
Update allocation edit toast copy
StephixOne e66f717
Create brown-wombats-jam.md
StephixOne d2bf35d
Merge branch 'develop' into fix/inventory-ui-fixes
StephixOne 2a1aa87
Merge branch 'develop' into fix/inventory-ui-fixes
srindom 60d2bd8
Merge branch 'develop' into fix/inventory-ui-fixes
StephixOne f44f5a2
Merge branch 'develop' into fix/inventory-ui-fixes
StephixOne c4edb72
Fix toast title on allocation deletion error
StephixOne 52912c5
Merge branch 'develop' into fix/inventory-ui-fixes
srindom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@medusajs/admin-ui": patch | ||
--- | ||
|
||
fix(admin-ui): Inventory and order UI fixes and tweaks |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very-nit(non-blocking): Should the title not be "Error" instead of "Errors", or even better a more descriptive title, like what you have done for the onSuccess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed "Errors" to "Error", but as far as I can tell, the "Error" title is very much standard in our codebase so far, I don't know if I'd want to have just the one be more verbose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's revisit our error messages some other time and merge this now thanks! 👍