fix(medusa): Update typescript types to reflect oas and return types (#…

…3344) * update typescript types to reflect oas and return types * add changeset --------- Co-authored-by: Oliver Windall Juhl <[email protected]>
medusajs · Feb 28, 2023 · 8424236 · 8424236
1 parent 589d1c0
commit 8424236
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/.changeset/quiet-deers-shake.md b/.changeset/quiet-deers-shake.md
@@ -0,0 +1,5 @@
+---
+"@medusajs/medusa": patch
+---
+
+Update types to reflect actual return-type
diff --git a/packages/medusa/src/api/routes/admin/inventory-items/index.ts b/packages/medusa/src/api/routes/admin/inventory-items/index.ts
@@ -230,11 +230,12 @@ export type AdminInventoryItemsListRes = PaginatedResponse & {
  *     description: The number of items per page
  */
 export type AdminInventoryItemsListWithVariantsAndLocationLevelsRes =
-  Partial<InventoryItemDTO> & {
-    location_levels?: InventoryLevelDTO[]
-    variants?: ProductVariant[]
+  PaginatedResponse & {
+    inventory_items: (Partial<InventoryItemDTO> & {
+      location_levels?: InventoryLevelDTO[]
+      variants?: ProductVariant[]
+    })[]
   }
-
 /**
  * @schema AdminInventoryItemsLocationLevelsRes
  * type: object

diff --git a/packages/medusa/src/api/routes/admin/inventory-items/list-inventory-items.ts b/packages/medusa/src/api/routes/admin/inventory-items/list-inventory-items.ts
@@ -3,10 +3,7 @@ import { IsBoolean, IsOptional, IsString } from "class-validator"
 import { Transform } from "class-transformer"
 import { IsType } from "../../../../utils/validators/is-type"
 import { getLevelsByInventoryItemId } from "./utils/join-levels"
-import {
-  getVariantsByInventoryItemId,
-  InventoryItemsWithVariants,
-} from "./utils/join-variants"
+import { getVariantsByInventoryItemId } from "./utils/join-variants"
 import {
   ProductVariantInventoryService,
   ProductVariantService,
@@ -128,17 +125,14 @@ export default async (req: Request, res: Response) => {
     inventoryService
   )
 
-  const variantsByInventoryItemId: InventoryItemsWithVariants =
-    await getVariantsByInventoryItemId(
-      inventoryItems,
-      productVariantInventoryService,
-      productVariantService
-    )
+  const variantsByInventoryItemId = await getVariantsByInventoryItemId(
+    inventoryItems,
+    productVariantInventoryService,
+    productVariantService
+  )
 
   const inventoryItemsWithVariantsAndLocationLevels = inventoryItems.map(
-    (
-      inventoryItem
-    ): AdminInventoryItemsListWithVariantsAndLocationLevelsRes => {
+    (inventoryItem) => {
       return {
         ...inventoryItem,
         variants: variantsByInventoryItemId[inventoryItem.id] ?? [],

diff --git a/packages/medusa/src/api/routes/admin/inventory-items/utils/join-variants.ts b/packages/medusa/src/api/routes/admin/inventory-items/utils/join-variants.ts
@@ -13,7 +13,7 @@ export const getVariantsByInventoryItemId = async (
   inventoryItems: InventoryItemDTO[],
   productVariantInventoryService: ProductVariantInventoryService,
   productVariantService: ProductVariantService
-): Promise<Record<string, InventoryItemsWithVariants>> => {
+): Promise<Record<string, ProductVariant[]>> => {
   const variantInventory = await productVariantInventoryService.listByItem(
     inventoryItems.map((item) => item.id)
   )