update pr with feedback

medusajs · Feb 22, 2023 · 4062974 · 4062974
1 parent 483b3a8
commit 4062974
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/packages/medusa/src/services/product-variant-inventory.ts b/packages/medusa/src/services/product-variant-inventory.ts
@@ -660,13 +660,12 @@ class ProductVariantInventoryService extends TransactionBaseService {
     variantInventoryItems: ProductVariantInventoryItem[],
     channelId: string
   ): Promise<number> {
-    if (
-      variantInventoryItems.length &&
-      variantInventoryItems.some(
-        (inventoryItem) =>
-          inventoryItem.variant_id !== variantInventoryItems[0].variant_id
-      )
-    ) {
+    const variantItemsAreMixed = variantInventoryItems.some(
+      (inventoryItem) =>
+        inventoryItem.variant_id !== variantInventoryItems[0].variant_id
+    )
+
+    if (variantInventoryItems.length && variantItemsAreMixed) {
       throw new MedusaError(
         MedusaError.Types.INVALID_DATA,
         "All variant inventory items must belong to the same variant"